Gettext translations cached after switching locale? about rails HOT 4 CLOSED

Hi @armandsar,

I tried to reproduce without success. I put that piece of code in a controller and it worked as expected:

def my_action
  I18n.locale = :fr
  puts _("Assigned")

  I18n.locale = :en
  puts _("Assigned")

  I18n.with_locale(:fr) do
    puts _("Assigned")
  end

  I18n.with_locale(:en) do
    puts _("Assigned")
  end
end

The output in the console was :

Assigné
Assigned
Assigné
Assigned

I tried in development with config.action_controller.perform_caching as true and false (we never know ^^). It was in a Rails 4 application.

What exactly is your stack so I could try to reproduce with the same one. Does it break also in development environment or only in production?

from rails.

I just tested the same example on a Rails 5.0.6 application and it worked too.

from rails.

Simplest bit of code i got to replicate this:

class TestController < ActionController::Base

  before_action :set_default_locale

  def index
    a = []
    a << [_('Dashboard'), I18n.locale]
    I18n.locale = 'lv'
    a << [_('Dashboard'), I18n.locale]
    render json: a
  end

  private

  def set_default_locale
    I18n.locale    = 'en'
    GetText.locale = 'en'
  end

end

Remove "GetText.locale = 'en'" line, reload page, translation still wrong.
Restart the server without gettext line and all is fine.

I now do realize that there is no need to set locale for GetText directly and I didn't really notice this until now, as this was implemented by another developer.

Still the behavior seems strange, given that we do call "I18n.locale = 'lv'" in controller action later..

I guess this can be closed :)

from rails.

I found out why it wasn't working: https://github.com/ruby-gettext/gettext/blob/master/lib/gettext.rb#L261-L282

GetText.locale= is the same as set_locale and fix the locale once for all the application (see the comments).

Gettext.current_locale= is the same as set_current_locale and is more flexible (many locales in the application).

This comment says all: # Note that if #set_locale is set, this value is ignored.

I tried your example with `current_locale=" and it's working. But as you noticed, Translation gem takes care of that for you so you don't have to worry about configuring the GetText locale: https://github.com/translation/rails/blob/master/lib/translation_io/railtie.rb#L21

from rails.