Git Product home page Git Product logo

Comments (11)

MaDDoGo avatar MaDDoGo commented on July 30, 2024

This is really important with multi-language: I tried to scrape "The Vampire Diaries" to know if the scrobbling is working (I have been using traktutilites for a long time, but without scrobbling only using the mark as seen behaviour) and in spanish it's called "Crónicas Vampíricas". Of course, the title isn't the same so there's not a match. Here are the important lines:

03:49:03 T:2957651968 NOTICE: [trakt] [Scrobbler] Watching: episode
03:49:05 T:2957651968 NOTICE: [trakt] json url: /show/watching/b6135e0f7510a44021fac8c03c36c81a17be35d9
03:49:06 T:2957651968 NOTICE: [trakt] traktQuery: Error: show not found
03:49:06 T:2957651968 NOTICE: [trakt] Error in request from 'watchingEpisodeOnTrakt()'

Maybe it's better to send the TheTVDB ID if there's one (ID+Snumber+Epnumber) and show / episode if there's no ID.

from script.trakt.

rectifyer avatar rectifyer commented on July 30, 2024

Agreed, this fix will make the plugin much better with international titles. Hoping to find a fix when I have some time to work on it.

from script.trakt.

MaDDoGo avatar MaDDoGo commented on July 30, 2024

I'll try to do the same I did with TU and make a pull request if you're ok with it.

from script.trakt.

dermarzel avatar dermarzel commented on July 30, 2024

I also recognized this bug and it would be awesome if this problem with scrobbling tv shows with different names than the english one gets solved! :)

from script.trakt.

rectifyer avatar rectifyer commented on July 30, 2024

Please download the latest github file and give it a try. It uses the tvdb_id now and is much more accurate at matching.

from script.trakt.

SimonHova avatar SimonHova commented on July 30, 2024

I can confirm that this fixed my issues. My TV shows scrobble perfectly now. Just need to get the update to my iPad. Thanks!

from script.trakt.

MaDDoGo avatar MaDDoGo commented on July 30, 2024

That's what i wanted to try. Genious :)

from script.trakt.

SimonHova avatar SimonHova commented on July 30, 2024

The iPad is working!

If anyone would like to manually update their iPads in the future, it was actually quite easy. You just have to add the zip file to an accessible server, and rename it to script.trakt . It wouldn't work until I renamed the file before installation.

from script.trakt.

dermarzel avatar dermarzel commented on July 30, 2024

Wow, that is awesome! Tried it with a lot of tv shows that did not work before and now it works like a charm! Fantastic job! Thanks a lot! :)

from script.trakt.

rectifyer avatar rectifyer commented on July 30, 2024

Glad to hear its working well! Please let me know if you find any issues over the next few days and if not I'll submit to the official repo.

from script.trakt.

dermarzel avatar dermarzel commented on July 30, 2024

Oh, bad news. Scrobbling works fantastically, but when the episode is over a little window pops with "Error: Show not found" and after that checking the history on trakt the episode is not marked as seen. :(

Edit: Wow, I was to slow and it's already fixed here (9450c7a). Tested this a few minutes ago and, of course, it works. I'm speechless... Nice work, rectifyer!

from script.trakt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.