Git Product home page Git Product logo

Comments (9)

apotonick avatar apotonick commented on July 17, 2024

Hi @AlfonsoUceda,

HTML printed in the application instead of rendering the slim file

how do you mean this?

from cells.

AlfonsoUceda avatar AlfonsoUceda commented on July 17, 2024

Hey @apotonick

Imaging having HTML printed in the browser as text, that you can see the HTML tags (raw HTML) so the it is not interpreted as HTML.

from cells.

apotonick avatar apotonick commented on July 17, 2024

That sounds like a problem with html_escape... I currently don't have resources for fixing this (we're using ERB everywhere), maybe you want to investigate?

from cells.

AlfonsoUceda avatar AlfonsoUceda commented on July 17, 2024

Will do @apotonick ;)

from cells.

apotonick avatar apotonick commented on July 17, 2024

My guess is you need to do safe_html! in safe_concat. It's not beautiful but neither is Rails' view layer! 🍻

from cells.

AlfonsoUceda avatar AlfonsoUceda commented on July 17, 2024

I've seen that this change in temple gem is the problem: judofyr/temple#135, reverting that change makes it work, but not sure if there is a way to fix it or wait until rails 7.1 is released because of the changes in Rails described in that PR and the implications in cell gems.

Could it be a problem for ERB too? because cells-erb uses erbse that uses temple gem.

from cells.

AlfonsoUceda avatar AlfonsoUceda commented on July 17, 2024

@apotonick what do you think about this?

from cells.

apotonick avatar apotonick commented on July 17, 2024

@AlfonsoUceda I see a comment that they believe it works with older Rails versions - aren't you saying that it doesn't work for you? Is Slim using Temple under the hood?

from cells.

AlfonsoUceda avatar AlfonsoUceda commented on July 17, 2024

Going to close this issue because I've opened one in cells-slim trailblazer/cells-slim#27

from cells.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.