API: /trains/checkin will always post a tweet about traewelling HOT 2 CLOSED

Hi, thanks for reporting this issue. The issue seems to be that the TransportController only checks whether the variable "tweet" exists (see

isset returns true, even if the variable itself is set to false:

<?php

var_dump(isset($a)); // => false

$a = null;
var_dump(isset($a)); // => false

$a = false;
var_dump(isset($a)); // => true

We would have to change the TransportController (see above) and deploy to prod, which can take longer time, but should definitely happen with that bug in mind. In the meantime, can you try sending "tweet": null or no tweet property at all?

I am sorry for the inconvenience that this issue might have caused.

from traewelling.

Sending "tweet": null will fail request validation:

{"error":{"tweet":["tweet muss wahr oder falsch sein."]}}

Trying to check in with valid data currently throws HTTP 500, so I will test not sending the "tweet" property later.

from traewelling.