Git Product home page Git Product logo

Comments (9)

pdxjohnny avatar pdxjohnny commented on June 3, 2024 1

@diabonas Only because I wasn't sure if exclude=... was enough. Thanks! Fixed in 0.1.3

from tpm2-pytss.

diabonas avatar diabonas commented on June 3, 2024 1

Awesome, building and running the tests works with the 0.1.3 release downloaded from PyPI, cheers!

from tpm2-pytss.

pdxjohnny avatar pdxjohnny commented on June 3, 2024

Damn it!!!

from tpm2-pytss.

pdxjohnny avatar pdxjohnny commented on June 3, 2024

Thanks for reporting, I'll fix ASAP

from tpm2-pytss.

lukehinds avatar lukehinds commented on June 3, 2024

Any plan to fix this still?

from tpm2-pytss.

pdxjohnny avatar pdxjohnny commented on June 3, 2024

Sorry for the delay I got a bit tripped up by https://bugs.python.org/issue37247 but I figured out a wordaround. Should be working in the 0.1.2 release. @diabonas @lukehinds @williamcroberts

from tpm2-pytss.

pdxjohnny avatar pdxjohnny commented on June 3, 2024

Let me know if it's not working for you

from tpm2-pytss.

diabonas avatar diabonas commented on June 3, 2024

I confirm that building from the PyPI sdist works again with version 0.1.2, thanks! One question, would it be possible to replace

tpm2-pytss/MANIFEST.in

Line 3 in e63d234

exclude tests/

by

include tests/*.py

so that tests are distributed on PyPI as well? This is helpful if you want to run the test suite before installation, e.g. for distribution packaging. The line

tpm2-pytss/setup.py

Line 214 in e63d234

packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]),
alone appears to be enough to avoid installing them to the site-packages directory (tested with both setuptools and pip).

I can create a PR if you want, but wanted to hear your motivation for including the exclude command first in case I am missing something here.

from tpm2-pytss.

diabonas avatar diabonas commented on June 3, 2024

Oh, and I noticed that 0.1.2 is not tagged in the Git repository, might be nice to do that here as well to keep in sync with the PyPI releases :)

from tpm2-pytss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.