php codesniffer warnings about civix HOT 2 CLOSED

For polyfill.php, the usage of $this looks fine to me. But I wouldn't be surprised if their pattern-matcher was little off. (This is an anonymous class inside an anonymous function... which is not very common.)

For [email protected], that probably is a latent bug (i.e. code is wrong; but currently I can't see a symptom). Fortunately, Eileen posted an update for [email protected] which incidentally fixes that. So I'll update the backport to use it.

from civix.

Thanks for reporting @jofranz. v23.03.0 is up and should include a fix for the smarty-v2 issue.

The polyfill.php is more awkward - since it looks like a false-negative to me. A few ways to go:

• Ignore it. (That's easiest from my POV...)
• Send a PR to the canonical polyfill.php and sprinkle in something like phpcs:ignore. (After that, we'd update civix.)
• Open an issue for phpcs/PHPCompatibility. Give them an example to test (e.g. an anonymous-class inside an anonymous-function). (If they can fix it, then that's the best outcome.)

from civix.