EngineIO: support standard of protocol about socketioxide HOT 6 CLOSED

ignores WebSocket connection with same sid after upgrade
I tried node.js engine.io server, it had the same behavior, the test failed.

from socketioxide.

ignores HTTP requests with same sid after upgrade issue is NOOP packet came before 4Hello. For me it reproduces with main and 0.2.0 tag also
this it the test log:

1) Engine.IO protocol
       upgrade
         ignores HTTP requests with same sid after upgrade:

      AssertionError: expected '6' to deeply equal '4hello'
      + expected - actual

      -6
      +4hello

Attaching pcaps dumps of nodejs server and rust
pcaps.zip

I dont think that is a big deal, but test can fail

from socketioxide.

Also I think it would be nice if someone added js test suites to ci or at least to this repo to check correctness of the server implementation

from socketioxide.

The test suite for socketio is already present in CI : https://github.com/Totodore/socketioxide/actions/workflows/socketio-ci.yml

For the Engine Io test suites it should only fail for : 1) ignores WebSocket connection with same sid after upgrade
The cause is that the implementation for this test is different between the socketio test suite & the engineio test suite. So I prefered to make the socketio pipeline work.

I opened an issue on the test-suite repo socketio/socket.io-protocol#29

For the error ignores HTTP requests with same sid after upgrade it should work.

Which branch did you test ?

from socketioxide.

When developing the Chat example (#17) I discovered high latency (10sec) when the socket was upgrading. Maybe it is linked.

from socketioxide.

@sleeyax maybe you could add the missing part for engineio v3 so the whole pipeline passes ?

from socketioxide.