Git Product home page Git Product logo

Comments (5)

n1t0 avatar n1t0 commented on August 17, 2024

Sure, it would be great and would certainly be useful to other users.

Your implementation looks good, just a few things about it:

  • The authentication is handled by call thanks to the use method.
  • From the results, we actually only give back the data part, as you can see in other methods.

Maybe you could try to add only one method which would looks like this:

subscribe = function(type, callback_url, options, cb) {

and handle the options according to the required type.

It would be awesome if you could add the relevant documentation as well.

Anyway, please feel free to make a pull request, we'll review it carefully.
Thanks in advance for your contribution!

from instagram-node.

konsumer avatar konsumer commented on August 17, 2024

or maybe this would more closely fit the spirit of the API:

subscribe = function(type, object_id, callback_url, options, cb){
}

from instagram-node.

n1t0 avatar n1t0 commented on August 17, 2024

Actually the interface is different for geographies as you provide lat and lng but not an object id.

from instagram-node.

konsumer avatar konsumer commented on August 17, 2024

Ah, too true. I don't mind making one for each, and it seems a bit simpler. Do you think it's better to just have 1 interface function?

from instagram-node.

n1t0 avatar n1t0 commented on August 17, 2024

No you're right, since the parameters for the geography subscription are different, one for each will be ok.

from instagram-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.