Git Product home page Git Product logo

Comments (3)

bdarnell avatar bdarnell commented on June 7, 2024

Try the recent changes in the master branch (specifically #3272). This will shut down the selector thread cleanly (without leaving it for atexit) as long as you're using asyncio.run.

I wonder if the atexit hook is even still necessary. As the comment says, I was never able to reproduce or understand it properly (it doesn't make sense for this to be necessary in a daemon thread). Now that we have a cleaner shutdown method, I'm not sure we really need the atexit hook as a fallback (but because it's so poorly understood I'm not confident we can remove it either).

from tornado.

graingert avatar graingert commented on June 7, 2024

Try the recent changes in the master branch (specifically #3272). This will shut down the selector thread cleanly (without leaving it for atexit) as long as you're using asyncio.run.

I don't expect this to work because my asyncio.run call needs to outlive the atexit callbacks

from tornado.

bdarnell avatar bdarnell commented on June 7, 2024

Ah, OK. So the existing changes won't help you and we either need to get rid of the atexit callback or give you a way to opt out. I'm leaning towards the former; it's really hard for a library to safely use an atexit callback and it doesn't feel necessary anymore. But we'll see if CI is happy when I make the change...

from tornado.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.