Git Product home page Git Product logo

Comments (7)

TorgoTorgo avatar TorgoTorgo commented on July 18, 2024

I've pushed up a version that uses hdiutil to create the dmg. hdiutil is bundled with macOS and so you shouldn't need to install anything with brew.

Please try this new version.

from ghidra-app-bundle.

feedface avatar feedface commented on July 18, 2024

It doesn't seem to catch the exception (not working, still):
[+] Extracted to /var/folders/_2/tjyb3yfs0y51r4b99xdhhkdm0000gq/T/tmp1v5flayo/Ghidra.app/Contents/Resources
[+] Building dmg
/bin/sh: genisoimage: command not found
hdiutil: create: Only one image can be created at a time.
Usage: hdiutil create [options]
hdiutil create -help
Traceback (most recent call last):
File "/Users/robthebrew/Desktop/Ghidra-App-Bundle/./update.py", line 171, in
subprocess.run(
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py", line 524, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'genisoimage -V "Ghidra 9.2.2" -D -R -apple -no-pad -o "Ghidra 9.2.2.dmg" "/var/folders/_2/tjyb3yfs0y51r4b99xdhhkdm0000gq/T/tmp1v5flayo"' returned non-zero exit status 127.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/Users/robthebrew/Desktop/Ghidra-App-Bundle/./update.py", line 174, in
subprocess.run(
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py", line 524, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'hdiutil create -volname "Ghidra 9.2.2" -fs HFS+ -srcfolder "/var/folders/_2/tjyb3yfs0y51r4b99xdhhkdm0000gq/T/tmp1v5flayo" Ghidra 9.2.2.dmg' returned non-zero exit status 1.

from ghidra-app-bundle.

TorgoTorgo avatar TorgoTorgo commented on July 18, 2024

Oh apologies, I see the issue. There's a missing quotation mark.

from ghidra-app-bundle.

TorgoTorgo avatar TorgoTorgo commented on July 18, 2024

I've just pushed a new commit. Please try again, this time it should work.

from ghidra-app-bundle.

feedface avatar feedface commented on July 18, 2024

Now it builds the dmg. However, the app bounces once and quits. I have tried code signing with no change. Console is giving me this:
May 5 14:25:48 MacBook-Air com.apple.xpc.launchd[1]: Coalition Cache Hit: app<application.gov.nsa.ghidra.13496623.13496627(503)> [19156]
May 5 14:25:48 MacBook-Air com.apple.xpc.launchd[1] (application.gov.nsa.ghidra.13496623.13496627[29810]): Service exited with abnormal code: 127
Note: the build I did using my suggestion in the OP works.
Also possibly related or not:
bash-3.2$ ./update.py --dmg
[!] Neither path nor url were specified!

from ghidra-app-bundle.

TorgoTorgo avatar TorgoTorgo commented on July 18, 2024

Can you please try running the Ghidra.app/Contents/MacOS/ghidra script directly from the terminal after building and extracting? The behaviour you described is what happens when the script can't find your JDK. You should at least get some output to help diagnose the issue.

Curious that your build with mkisofs works... Can you run the script directly as I described above and compare the output? It might also be worthwhile trying the --tar option.

Please note with the codesigning: I have placed the Ghidra install (which contains executables) into Resources which is a "non-code place". This will surely lead to an invalid bundle sig if you sign with --deep.

from ghidra-app-bundle.

feedface avatar feedface commented on July 18, 2024

Sorry, my bad. As I had my successfully built app, I saved the latest as Ghidra 2.app. That screws up the load script as it is hardwired to expect just Ghidra.app. Working successfully once renamed.
However, the ./update.py --dmg does not work without a url (eg as in your second example).

from ghidra-app-bundle.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.