Cant pass extensionId validation about semantic-release-firefox-add-on HOT 3 OPEN

For manifest v3 the ID is required in manifest.json, so the current validation in semantic-release-firefox-add-on is incompatible. I ended up applying a similar patch as synox using patch-package, and it worked as a charm.

diff --git a/node_modules/semantic-release-firefox-add-on/src/constants.js b/node_modules/semantic-release-firefox-add-on/src/constants.js
index c5dea36..2e34ade 100644
--- a/node_modules/semantic-release-firefox-add-on/src/constants.js
+++ b/node_modules/semantic-release-firefox-add-on/src/constants.js
@@ -11,8 +11,6 @@ const defaultOptions = {
 }
 
 const requiredOptions = {
-    extensionId:
-        'Omitting this would create a new extension instead of a new version.',
     targetXpi:
         'Omitting this would leave the xpi file unnamed when it is returned from mozilla.',
 }
diff --git a/node_modules/semantic-release-firefox-add-on/src/publish.js b/node_modules/semantic-release-firefox-add-on/src/publish.js
index ad0f63d..6c3ce35 100644
--- a/node_modules/semantic-release-firefox-add-on/src/publish.js
+++ b/node_modules/semantic-release-firefox-add-on/src/publish.js
@@ -16,7 +16,6 @@ const publish = async options => {
     // the console which will lead to the validation page which should contain
     // detailed reasons why the extension was rejected
     const {
-        extensionId,
         artifactsDir,
         channel,
         sourceDir,
@@ -46,7 +45,6 @@ const publish = async options => {
             apiSecret: FIREFOX_SECRET_KEY,
             artifactsDir,
             channel,
-            id: extensionId,
             sourceDir,
         },
         { signAddon },

from semantic-release-firefox-add-on.

This still does not work. I created a fork that relies on the id in the manifest.json, and ignores the provided id.
https://github.com/synox/semantic-release-firefox-add-on

from semantic-release-firefox-add-on.

For manifest v3 the ID is required in manifest.json, so the current validation in semantic-release-firefox-add-on is incompatible. I ended up applying a similar patch as synox using patch-package, and it worked as a charm.

diff --git a/node_modules/semantic-release-firefox-add-on/src/constants.js b/node_modules/semantic-release-firefox-add-on/src/constants.js
index c5dea36..2e34ade 100644
--- a/node_modules/semantic-release-firefox-add-on/src/constants.js
+++ b/node_modules/semantic-release-firefox-add-on/src/constants.js
@@ -11,8 +11,6 @@ const defaultOptions = {
 }
 
 const requiredOptions = {
-    extensionId:
-        'Omitting this would create a new extension instead of a new version.',
     targetXpi:
         'Omitting this would leave the xpi file unnamed when it is returned from mozilla.',
 }
diff --git a/node_modules/semantic-release-firefox-add-on/src/publish.js b/node_modules/semantic-release-firefox-add-on/src/publish.js
index ad0f63d..6c3ce35 100644
--- a/node_modules/semantic-release-firefox-add-on/src/publish.js
+++ b/node_modules/semantic-release-firefox-add-on/src/publish.js
@@ -16,7 +16,6 @@ const publish = async options => {
     // the console which will lead to the validation page which should contain
     // detailed reasons why the extension was rejected
     const {
-        extensionId,
         artifactsDir,
         channel,
         sourceDir,
@@ -46,7 +45,6 @@ const publish = async options => {
             apiSecret: FIREFOX_SECRET_KEY,
             artifactsDir,
             channel,
-            id: extensionId,
             sourceDir,
         },
         { signAddon },

Thank you for this ! This got me unblocked. Hopefully a fix for this can be implemented soon

from semantic-release-firefox-add-on.