Comments (3)
For manifest v3 the ID is required in manifest.json
, so the current validation in semantic-release-firefox-add-on
is incompatible. I ended up applying a similar patch as synox using patch-package
, and it worked as a charm.
diff --git a/node_modules/semantic-release-firefox-add-on/src/constants.js b/node_modules/semantic-release-firefox-add-on/src/constants.js
index c5dea36..2e34ade 100644
--- a/node_modules/semantic-release-firefox-add-on/src/constants.js
+++ b/node_modules/semantic-release-firefox-add-on/src/constants.js
@@ -11,8 +11,6 @@ const defaultOptions = {
}
const requiredOptions = {
- extensionId:
- 'Omitting this would create a new extension instead of a new version.',
targetXpi:
'Omitting this would leave the xpi file unnamed when it is returned from mozilla.',
}
diff --git a/node_modules/semantic-release-firefox-add-on/src/publish.js b/node_modules/semantic-release-firefox-add-on/src/publish.js
index ad0f63d..6c3ce35 100644
--- a/node_modules/semantic-release-firefox-add-on/src/publish.js
+++ b/node_modules/semantic-release-firefox-add-on/src/publish.js
@@ -16,7 +16,6 @@ const publish = async options => {
// the console which will lead to the validation page which should contain
// detailed reasons why the extension was rejected
const {
- extensionId,
artifactsDir,
channel,
sourceDir,
@@ -46,7 +45,6 @@ const publish = async options => {
apiSecret: FIREFOX_SECRET_KEY,
artifactsDir,
channel,
- id: extensionId,
sourceDir,
},
{ signAddon },
from semantic-release-firefox-add-on.
This still does not work. I created a fork that relies on the id in the manifest.json, and ignores the provided id.
https://github.com/synox/semantic-release-firefox-add-on
from semantic-release-firefox-add-on.
For manifest v3 the ID is required in
manifest.json
, so the current validation insemantic-release-firefox-add-on
is incompatible. I ended up applying a similar patch as synox usingpatch-package
, and it worked as a charm.diff --git a/node_modules/semantic-release-firefox-add-on/src/constants.js b/node_modules/semantic-release-firefox-add-on/src/constants.js index c5dea36..2e34ade 100644 --- a/node_modules/semantic-release-firefox-add-on/src/constants.js +++ b/node_modules/semantic-release-firefox-add-on/src/constants.js @@ -11,8 +11,6 @@ const defaultOptions = { } const requiredOptions = { - extensionId: - 'Omitting this would create a new extension instead of a new version.', targetXpi: 'Omitting this would leave the xpi file unnamed when it is returned from mozilla.', } diff --git a/node_modules/semantic-release-firefox-add-on/src/publish.js b/node_modules/semantic-release-firefox-add-on/src/publish.js index ad0f63d..6c3ce35 100644 --- a/node_modules/semantic-release-firefox-add-on/src/publish.js +++ b/node_modules/semantic-release-firefox-add-on/src/publish.js @@ -16,7 +16,6 @@ const publish = async options => { // the console which will lead to the validation page which should contain // detailed reasons why the extension was rejected const { - extensionId, artifactsDir, channel, sourceDir, @@ -46,7 +45,6 @@ const publish = async options => { apiSecret: FIREFOX_SECRET_KEY, artifactsDir, channel, - id: extensionId, sourceDir, }, { signAddon },
Thank you for this ! This got me unblocked. Hopefully a fix for this can be implemented soon
from semantic-release-firefox-add-on.
Related Issues (17)
- Better error handling HOT 1
- publishment fails with default parameters due to referring to `artifacts/artifacts/XXX.xpi` HOT 1
- Replace semantic-release-firefox with semantic-release-firefox-add-on in community plugin list HOT 7
- Ability to provide source code, release notes, and reviewer notes HOT 1
- Add eslinting to source code
- Enable branch protection HOT 1
- Weird behaviour in `github-actions` CI/CD pipeline HOT 4
- The automated release is failing 🚨 HOT 43
- The automated release is failing 🚨 HOT 6
- Allow publishing of pre-release version
- Top Hat Semantic Release Firefox Add-on Icon HOT 1
- Configure channel notifications HOT 1
- Fails when submitting a listed add-on HOT 6
- Improve test coverage HOT 1
- Cannot install v0.2.3 HOT 2
- Integration test should run all steps to verify implementation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semantic-release-firefox-add-on.