Comments (2)
The problem is caused by int32_t arithmetic overflow...
Below is an example:
When performing one of below statements in the loop of shine_mdct_sub() of l3mdct.c:
muladd(vm, vm_lo, mdct_in[?], config->mdct.cos_l[k][?]);
with
vm=-0.920113(0x8a39bcbc)
mdct_in=0.234619(1e07fed1)
cos_l=-0.711309(a4f3d3a3)
vm will be 0.996444(7f8b7793) but not -1.003556 (0xffffffff7f8b7793) because there is no room for signature.
Many other points in the source code can cause the same problem. My dirty and fast solution is to replace all int32_t of fixed point number arithmetic with int64_t. It works fine with 10KHz full-amplitude input but not with 500Hz full-amplitude input. It is necessary to dig deeper.
from shine.
Thanks for the report, that seems like an interesting issue, I'll have a look at it soon.
from shine.
Related Issues (20)
- How to build so on linux? HOT 2
- COPYING should be updated HOT 1
- Compiling Error on Rpi2 Wheezy HOT 1
- No support for live stream sources? HOT 3
- (Enhancement-Wish) Allow FFmpeg to compile with static libshine and libmp3lame libraries. HOT 2
- make error at 3.1.0
- License question HOT 8
- Psymodel HOT 2
- Quality comparison HOT 2
- ffmpeg:ERROR: shine not found using pkg-config HOT 30
- I use this code in STM32 HOT 1
- Wave header parser isn't generic enough HOT 9
- Can encoder be used after shine_flush HOT 1
- BIG_ENDIAN problem (Error: Unknown WAVE format) HOT 3
- Can't reproduce emcc build of js/dist/libshine.js
- Final frame may be truncated
- Frame header padding bit incorrectly set
- bit of an odd include process for cpp users
- This seems to build Shine on Windows (CMakeLists.txt)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shine.