Selecting devices under windows about node-speaker HOT 8 CLOSED

I've managed to get the output selection working, the correct device name was being passed to the audio object constructor in index.js, but when the open event was called this has been replaced by another 'device' object which I was defining elsewhere. I must have some bad 'this' scoping somewhere, but it was resolved by a quick rename of my other device variable.

from node-speaker.

Just stumbled across this:
https://sourceforge.net/p/mpg123/bugs/288/

I'm not sure if this means it's not possible to select output devices under windows with node-speaker then?

from node-speaker.

Just submitted a PR to fix this (#154) since I was running into the same problem.

from node-speaker.

I've been testing your version (by forking and releasing privately), but don't seem to be having much luck. I threw in a couple of printf's to see whats going on, but it always seems to think I am not specifying a device. i.e. i always get "Test2b" not "Test2a" from the below:

    if (ao->device) {
        /* Find device id of device with the same name as ao->device */
        /* Device names from waveOutGetDevCaps are limited to 32  */ 
        /* characters, so truncate ao->device for comparison */ 
        printf("Test2a");
        ao->device[31] = '\0';
        for (UINT i = 0; i < waveOutGetNumDevs(); ++i) {
            WAVEOUTCAPS caps;
            waveOutGetDevCaps(i, &caps, sizeof(WAVEOUTCAPS));
            if (!strcmp(ao->device, caps.szPname)) {
                dev_id = i;
                break;
            }
        }
    } else {
        printf("Test2b");
        ao->device = "WaveMapper";
    }

@nacgarg did you initialise the speaker object and define the output device differently to my code below? I'm not sure why my device is not getting passed through. Dev_n is my long device name (e.g. "Speakers (USB PnP Sound Device)"), but even if that was spelt wrong it should still try to first if branch?

this.ospeaker = require('speaker');
this.audio_devices_array[a_num].ao = new this.ospeaker({
					  channels: 2,
					  bitDepth: 16,
					  sampleRate: 48000,  
					  device: dev_n
					});

from node-speaker.

Hmm, that's strange. I'm initializing the speaker object pretty much the same way as you. Can you check to see if ao->device is defined here (maybe add a printf("device: %s", ao->device))? https://github.com/TooTallNate/node-speaker/blob/master/src/binding.c#L60

from node-speaker.

Also, if you want to test my fork without going through the hassle of privately releasing, you can just add "speaker": "https://github.com/nacgarg/node-speaker" to your package.json IIRC.

from node-speaker.

It seems that " if (is_string(env, args[3])) {" is not resolving true, so line 60 never gets called. Not sure why right now, I'm learning C++ as we go! I'll see if I can get any more details out later.

Thanks on the second point, I thought my way seemed a bit excessive, I'm still getting to grips with Github

from node-speaker.

Interesting, do you want to try just passing the string in directly? Maybe there's something strange with your dev_n string? So try something like

new this.ospeaker({
	channels: 2,
	bitDepth: 16,
	sampleRate: 48000,  
	device: "Speakers (USB PnP Sound Device)"
});

from node-speaker.