Git Product home page Git Product logo

Comments (6)

Bikingman avatar Bikingman commented on September 13, 2024

Do you think it's worth leveraging a floor to round the values instead of completely filtering out the values? e.g., if quote(s) exist and first two characters are numbers, use those values. If I'm reading this code correctly, this adjustment would preserve more information

from pybna.

brendanbikes avatar brendanbikes commented on September 13, 2024

@Bikingman I like that approach - we'd probably want to retain the next character after the initial number(s) to allow interpretation of units, and just toss out the rest of the field in the identified cases of more numbers immediately following the unit signifier.

from pybna.

Bikingman avatar Bikingman commented on September 13, 2024

Yea, that makes sense to avoid misinterpreting a few inches as a few feet. Does the width attribute on the resulting ways table up as a integer value? Wondering if there are any issues in retaining the right side unit character

from pybna.

brendanbikes avatar brendanbikes commented on September 13, 2024

These fields get mapped to tf_bike_infra_width and ft_bike_infra_width, which along with the roads width field are all reals.

The interpreter looks for 'ft' or 'm' unit characters (see

WHEN osm."cycleway:right:width" LIKE '% ft'
), but not single or double quote marks, so I think here we want to:

  1. replace single quotes with ' ft' and scrap the rest of the field
  2. toss out any field entirely where the first-from-left unit signifier is a double quote, because inches doesn't make sense

from pybna.

brendanbikes avatar brendanbikes commented on September 13, 2024

Also I think we only need to do this with fields that are typically numeric, not all of them

from pybna.

Bikingman avatar Bikingman commented on September 13, 2024

Yea, that sounds good to me to preserve as much information as possible while not over estimating width estimates.

from pybna.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.