Comments (6)
Do you think it's worth leveraging a floor to round the values instead of completely filtering out the values? e.g., if quote(s) exist and first two characters are numbers, use those values. If I'm reading this code correctly, this adjustment would preserve more information
from pybna.
@Bikingman I like that approach - we'd probably want to retain the next character after the initial number(s) to allow interpretation of units, and just toss out the rest of the field in the identified cases of more numbers immediately following the unit signifier.
from pybna.
Yea, that makes sense to avoid misinterpreting a few inches as a few feet. Does the width attribute on the resulting ways table up as a integer value? Wondering if there are any issues in retaining the right side unit character
from pybna.
These fields get mapped to tf_bike_infra_width and ft_bike_infra_width, which along with the roads width field are all reals.
The interpreter looks for 'ft' or 'm' unit characters (see
pybna/pybna/sql/importer/roads/15_bike.sql
Line 171 in 6110a73
- replace single quotes with ' ft' and scrap the rest of the field
- toss out any field entirely where the first-from-left unit signifier is a double quote, because inches doesn't make sense
from pybna.
Also I think we only need to do this with fields that are typically numeric, not all of them
from pybna.
Yea, that sounds good to me to preserve as much information as possible while not over estimating width estimates.
from pybna.
Related Issues (20)
- Eliminate most crosswalks HOT 7
- Neighborhood-level assumptions
- Metric conversion HOT 1
- Methodology changes
- Check oneway handling HOT 1
- One way bike lanes HOT 1
- Texas import errors out HOT 1
- Non-standard schemas not accepted for lookup_tables HOT 2
- Madison Comparison HOT 3
- Better Travel Sheds
- QC methods HOT 1
- new argument name to ox.config HOT 2
- Upgrade to osmnx 1.0 HOT 1
- Add name to BNA importer HOT 2
- change Census block vintage? HOT 1
- Error Encountered while using pybna python library "InvalidTextRepresentation: malformed array literal: "{6'0"}" DETAIL: Unexpected array element.' HOT 2
- Shapely version 2.0 not compatible HOT 2
- Destinations import from overpass not working with multiple tags HOT 1
- Discrepancy between imports from PBF and from overpass
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pybna.