Wrong ligature for ?: about firacode HOT 6 CLOSED

Removed in 1.000

from firacode.

I know, I’ll remove it in the next version. If you’re curious why it was
there in the first place, :? is called Elvis operator

On Sat, Oct 31, 2015 at 3:09 AM Guilherme Bernal [email protected]
wrote:

I'm using Atom 1.1 with Fira Code (It's awesome!), but I noticed ?:
renders to a quite odd symbol.

This is the plain text:

type U = {
aaa?: string // ?: means an optional property
bbb?: number
}

function F(aaa?: string, bbb?: number) {
// ?: means an optional parameter
}

Here is what I see:

https://camo.githubusercontent.com/a5920ad8a231b8d80f307481d63c3249e5e9de5f/687474703a2f2f6c626775696c6865726d652e636f6d2f73637265656e73686f742f37636534663635376463393665383261323230373166666630326130663865622e706e67

This strange ligature symbol makes no sense to me, it would be better to
have no ligature at all here.

—
Reply to this email directly or view it on GitHub
#61.

from firacode.

👍

from firacode.

👍

from firacode.

?: is also used in regex for non-captured groups.

In any case, a ligature for ?: isn't exactly a bad idea but perhaps maybe just a condensed form like what is used for ?=. (Sidenote: what is that symbol and where did it come from? o_0 )

from firacode.

@MadcapJake The symbol is clearly a portrait of Elvis... ;) But +1 vote for the issue, it drives me nuts as well.

from firacode.