Git Product home page Git Product logo

Comments (2)

Zenithsiz avatar Zenithsiz commented on June 12, 2024

It should be possible to rename the variant itself and add a deprecated const item to the impl with the previous variant (or just add STX as the const item).
Something as such:

impl AsciiChar {
    #[deprecated("Use `AsciiChar::STX`")]
    pub const SOX: Self = Self::STX;
}

This should be technically non-breaking, even in match arms, as AsciiChar is both PartialEq and Eq, but not sure if it could break elsewhere.

from rust-ascii.

tormol avatar tormol commented on June 12, 2024

Renaming the variant breaks uses, both globs and explicit:

use ascii::AsciiChar::*; // Warning, unused.
let _ = SOX; // Error, did you mean SO?
use AsciiChar::SOX; // Error, did you mean SOH?

I couldn't find much about importing associated constants, other than a thread saying it's not supported and another thread explaining why. (the linked reference page doesn't make it clear at all).

I'll deprecate the variant, and then maybe rename with associated constant as fallback in a later version.

On the other hand I doubt which way it's done matters,
as I assume the only reason to glob-import will be to create a hardcoded &AsciiStr from &[AsciiChar] with printable characters. And useing select characters seems rather pointless.

from rust-ascii.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.