Comments (3)
Kiiyya
commented on May 28, 2024
2
I think a functionality to get the architecture of an executable/process would be super convenient. Setting it to native by default creates issues like I ran into, debugging things which are difficult to debug, since most of the time copying 8 byte pointers instead of 4 bytes pointers will work just fine (if there's an extra few zeros just by chance), but then some other times it will fail. And it's not obvious what causes that. Imagine users just assuming the library knows what it's doing. Also, at least trying to consult IsWow64Process is better than just blindly choosing native architecture. I'll have a look into whether determining arch will be possible on Linux on the weekend.
I'd suggest something like my_raw_handle.try_into_arch(), which returns a Option<Architecture> (or Result), which then has to be used with .try_into_process_handle. I would remove .set_arch then, since an architecture doens't just change during runtime, heh. Though this is just a first wild suggestion, maybe something more fancy with traits can be thought of.
As far as I know, there exists IsWow64Process2 which had something mentioned about ARM, but I'll look into that on the weekend.
from rs-process-memory.
Kiiyya
commented on May 28, 2024
A fix (for Windows only. Issue remains on Linux/macOS) is here: Kiiyya@707eae2
But since it's based on #4 I won't open a PR yet.
from rs-process-memory.
Tommoa
commented on May 28, 2024
I think you might have missed that `Architecture`s work on `ProcessHandle`s and should be called on them.
So some working code for you might be something like:
```rs
let process_handle = get_pid("32-bit.exe").try_into_process_handle()?;
let process_handle = process_handle.set_arch(Architecture::Arch32Bit);
let member = ...
```
The reason for this structure is that even though you can (likely) determine the correct architecture of a Windows program by looking for `SysWOW64`, I don't think that the same can be done for Linux and OSX and I'm not sure about trying to include functionality that doesn't work on all supported OSes and may not even function correctly across different architectures (e.g. does SysWOW64 still exist to show 32-bit programs on Windows on ARM?).
Please let me know if this solves your issue or if you think that there might still be room for improvement on handling varying architectures.
from rs-process-memory.
Related Issues (8)
- `DataMember::read` is unsound HOT 3
- Expose rs-process-memory as a simple cdylib
- Generic type for offsets
- Move architecture handling to be on `ProcessHandle`s, not `DataMember`s
- A way to read strings? HOT 4
- Cannot create ProcessHandle on macOS HOT 2
- Only part of a ReadProcessMemory or WriteProcessMemory request was completed. HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rs-process-memory.