Git Product home page Git Product logo

Comments (1)

tomastrajan avatar tomastrajan commented on May 14, 2024 1

Hey @JanOschii !

Thank you for reporting the issue! I was aware of this and it was pretty harmless but I agree we are better of without weird warning in the console!

The issue was caused by the fact that the theme class was added to the main DOM container only after application already started. AppComponent subscribes to the store to retrieve theme class and apply it on the overlayContainer and main DOM container. This means app has to exist for some time before this happens without theme css.

The solution is to enable default theme by default by removing theme class around it usage in styles.scss. (feel free to check the commit) That way default theme is applied before app startup and the warning is removed.

Your proposed solution would work but increase the payload of application significantly because we would be shipping extra theme which would never be really used.

Cheers!

from angular-ngrx-material-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.