Git Product home page Git Product logo

Comments (3)

tomastrajan avatar tomastrajan commented on May 14, 2024

Hey Jan!

Happy to hear that you like the project! The deal with the themes folder is that it is defined in angular-cli.json file in stylesPreprocessorOptions and includePaths.

To make it work in WebStorm set themes folder as resource root.

ps: I use Intellij IDEA so had to deal with it too 😉

from angular-ngrx-material-starter.

JanOschii avatar JanOschii commented on May 14, 2024

Hey Tomas,

i see. But its still defined in .angular-cli.json

      "stylePreprocessorOptions": {
        "includePaths": ["./", "./themes"]
      },

Maybe it works with WebStorm but fails with PhpStorm?
Do you see any problem, if I keep the import statements with the subfolder?

Jan

from angular-ngrx-material-starter.

tomastrajan avatar tomastrajan commented on May 14, 2024

Hey @JanOschii !

I gave it a bit more thought and realized you're right. Original solution is not obvious (more like magic) plus it doesn't work in some IDEs by default.

So I removed "./themes" from includePathsand used full theme imports instyles.scss` instead.

As for "./", the story is bit more complicated because it is used for imports of styles-variables.scss which is used by many components and the relative imports would get pretty messy very fast (eg: ../../../../styles-variables.scss) so I would still be in favour of using include paths for that even though IDE would complain without setting it up properly...

Anyway thank you for your contribution.

Cheers!

from angular-ngrx-material-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.