Git Product home page Git Product logo

Comments (3)

twata1 avatar twata1 commented on June 25, 2024

If 02_code.t hangs on Windows under Strawberry Perl version 5.14.4 or higher,
this patch might be helpful.

I tested Strawberry Perl:
v5.14.4
v5.18.4
v5.20.3
v5.22.2
v5.24.0
on Windows 7(32bit).
)

Hope this help.

Thank you,

--
twata

Guard.pm.StrawberryP5-14-4.txt

from proc-guard.

nponeccop avatar nponeccop commented on June 25, 2024

It still hangs with Strawberry 5.26 64 bit/Windows Server 2016

from proc-guard.

nponeccop avatar nponeccop commented on June 25, 2024

I did some investigation, and it seems we need to replace the kill code with kill_gently() from IPC::Cmd:

https://github.com/jib/ipc-cmd/blob/ecf96f1f73ecc340bb2ff211b70a435ab52e003b/lib/IPC/Cmd.pm#L464-L521

Unfortunately it's not documented, so the only way is copy-paste. IPC::Cmd is in core_perl so it's well-tested everywhere including Windows, so it's a good place to borrow code from. And we'll get graceful killing for free.

The patch by @twata1 is the poor man's version of it (uses the same approach).

I'll upload a TRIAL release on CPAN using my handle and test reverse dependencies or Proc::Guard with it. Then I can take maintenance of this package (my pause handle is NML)

from proc-guard.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.