Git Product home page Git Product logo

Comments (4)

TogAr2 avatar TogAr2 commented on August 23, 2024 1

Hey Jasper!

I finally decided to get back into this project. It is now completely updated to the latest Minestom version (along with several improvements to projectiles). I haven't done rigorous testing yet but everything seems to be working.

I looked at your fork and it seems to me that some solutions are a little hacky. I think its best to not integrate those in the original repository. You are however very welcome to contribute to this repository! I think it's great you're willing to help improving the library.

Could you maybe give me a list of all the things that you fixed in your version, so I can take a look at it? Of course you can also just open a pull request if you want. Also, what exactly are the sound errors you are talking about?

from minestompvp.

JasperTheMinecraftDev avatar JasperTheMinecraftDev commented on August 23, 2024

I've created a fork of this project which removes removes the Extension class which effectively renders it unusable as a extension but it works fine as a library. The fork can be found in my repositories if anyone needs it. Hopefully a official solution will be provided soon!

from minestompvp.

JasperTheMinecraftDev avatar JasperTheMinecraftDev commented on August 23, 2024

I've also fixed the sound errors in my fork. Is this still maintained? Otherwise I can maybe take it over.

from minestompvp.

JasperTheMinecraftDev avatar JasperTheMinecraftDev commented on August 23, 2024

Hey Jasper!

I finally decided to get back into this project. It is now completely updated to the latest Minestom version (along with several improvements to projectiles). I haven't done rigorous testing yet but everything seems to be working.

I looked at your fork and it seems to me that some solutions are a little hacky. I think its best to not integrate those in the original repository. You are however very welcome to contribute to this repository! I think it's great you're willing to help improving the library.

Could you maybe give me a list of all the things that you fixed in your version, so I can take a look at it? Of course you can also just open a pull request if you want. Also, what exactly are the sound errors you are talking about?

Hey!

Awesome that you decided to start working on MinestomPvP again. Can't recall the sound issue but lots of things were done, you can check it using the commits, they describe the fixed stuff. About the extension class being removed, that's because extensions have been removed from Minestom as a whole. So not really hacky :)

from minestompvp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.