Git Product home page Git Product logo

Comments (3)

thorseraq avatar thorseraq commented on May 18, 2024

I have met this when tests as basic indent and unindent fails as well, and would like to give more information :)

Pic below shows when the test accidentally fails, the state of formattedJSX, which is serialized from window.store is not updated according to the last await pressShiftTab(page) (Confusing for me so far).

The callstack is: basic indent and unindent -> await assertStoreMachJSX -> expect(snapshot.trimStart(), formattedJSX).toEqual(formattedJSX);

image

from blocksuite.

doodlewind avatar doodlewind commented on May 18, 2024

Some findings over recent development:

  • Some asserters are sensitive to mouse movement, adding await page.mouse.move(100, 100) makes it stable.
  • Some consecutive operations may be merged into unexpected undo stack items. Explicitly adding page.captureSync() in the application code makes it stable.
  • To investigate a flaky test, we can mark one test case as test.only, then perform npx playwright test --repeat-each=10. It's also very helpful to run pnpm test -- --debug with await page.pause() added before certain asserters.

cc @lawvs @himself65 @thorseraq

from blocksuite.

doodlewind avatar doodlewind commented on May 18, 2024

We can get reports about flaky test after #728, and we also have some examples about fixing flaky tests:

They are mostly about timeout.

Closing this issue since we plan to fix other flaky tests case-by-case.

from blocksuite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.