FileHandle behaviour is different between Type::Tiny and Type::Tiny::XS about p5-type-tiny HOT 7 CLOSED

Really the whole question of what is and is not considered a file handle in Perl is a little muddy. Whether IO::String objects should be considered to be file handles could be argued either way. I don't think either behaviour you observe is really incorrect, however it would be nice if they were consistent.

Do you have a suggested fix?

from p5-type-tiny.

I think making Types::Standard match the Type::Tiny::XS behaviour (i.e. considering IO::String a FileHandle) is more desirable.

I don't have a patch because I was not quite able to follow the XS function enough to spot the difference between the pure Perl check and the check in C.

from p5-type-tiny.

To clarify, I do agree it could be argued either way. As long as it's consistent, that's fine by me. Personally, I think IO::String should be considered a FileHandle.

from p5-type-tiny.

Okay, so the current pure Perl check is:

	(ref($_) eq "GLOB" && Scalar::Util::openhandle($_))
	or (blessed($_) && $_->isa("IO::Handle"))

I think it can be made consistent with the XS by changing it to:

	(Scalar::Util::reftype($_) eq "GLOB" && Scalar::Util::openhandle($_))
	or (blessed($_) && $_->isa("IO::Handle"))

Advantages:

• Makes Type::Tiny and Type::Tiny::XS consistent.
• Allows IO::String to pass the type constraint.
• Makes Type::Tiny and Mouse consistent.

Disadvantages:

• Inconsistent with Moose.
• Breaks encapsulation by caring about the reftype of a blessed object.

from p5-type-tiny.

MooX::Types::MooseLike::Base uses this check:

(defined($_) && Scalar::Util::openhandle($_))
or (blessed($_) && $_->isa("IO::Handle"))

That's a fairly nice solution. Doesn't break encapsulation. The following might fail faster in the case of non-references:

(ref($_) && Scalar::Util::openhandle($_))
or (blessed($_) && $_->isa("IO::Handle"))

from p5-type-tiny.

Moved to RT.
https://rt.cpan.org/Ticket/Display.html?id=121762

from p5-type-tiny.

Fixed in dev version 1.003_001.

from p5-type-tiny.