make domtext work with static pages about tw5-dom HOT 5 CLOSED

Hi @tobibeer as we've discussed it elsewhere, I guess you know that the macro doesn't comply with the rules for a macro because its output isn't purely a function of its parameters.

Anyhow, macros shouldn't reference the global document object (one reason being that it's not available under Node.js). Instead, use the document property of the widget object ie this.document.

It's not a foolproof check for static site generation, but you can check whether the document is TW's fakedom implementation, which would normally be sufficient:

if(this.document.isTiddlyWikiFakeDom) {
...
}

from tw5-dom.

Thanks, @Jermolene, I imagined it involved fakedom, although I expected it would ship with its own getElementById() and then saw that it doesn't.

its output isn't purely a function of its parameters

Assuming that states and temporary tiddlers keep representation in sync with the store, it is very much so, at least for the very purpose for which it was created: to read (and only read) the inner contents of the calc widget, being some calculated output.

Should the widget output change, then precisely due to a change of tiddlers in the store that affect the computation, hence the very need to also update this macro's output... which works when used as an element attribute, but not standalone, which is ok.

you can check whether the document is TW's fakedom implementation

Thanks, I have modified the code accordingly, and added basic getElementById() support to fakedom.

@Jermolene: Shall I make a PR with respect to getElementById() for fakedom?

from tw5-dom.

Assuming that states and temporary tiddlers keep representation in sync with the store, it is very much so

No, it is not. The output of the macro depends on the DOM which, in the examples you are talking about, depends on the tiddler store. So, the output of the macro is dependent upon the state of the tiddler store (as well as it's parameters). That means that it conflicts with the refresh mechanism.

Thanks, I have modified the code accordingly, and added basic getElementById() support to fakedom.

The way that you've copied the code makes it very hard to use GitHub to see what changes have been made to the underlying core file. I wouldn't be keen to accept getElementById() into the core fakedom implementation because I don't think it's at best not generally useful and at worst rather dangerous. So I'd advise monkey-patching your modification into the core fakedom implementation, rather than forking it.

from tw5-dom.

@Jermolene,

So, the output of the macro is dependent upon the state of the tiddler store (as well as it's parameters).

This statement appears true for every single macro. (How) Is it not?

The way that you've copied the code makes it very hard to use GitHub to see what changes have been made to the underlying core file.

I know, hence my question for a PR. I'll make one just to show the diff.

I wouldn't be keen to accept getElementById() into the core fakedom implementation because I don't think it's at best not generally useful and at worst rather dangerous.

That I'll leave for you to decide. I would not know what could be dangerous about indexing ids.

So I'd advise monkey-patching your modification into the core fakedom implementation, rather than forking it.

You mean by overwriting it the way I do or via some other means of "extending" it? (Would you have a few lines of (pseudo-)code on how to do that?)

from tw5-dom.

I made a PR to show the diff for a basic getElementById() support in fakedom:

TiddlyWiki/TiddlyWiki5#2095

from tw5-dom.