Add Shellcheck CI checks about magtape HOT 5 CLOSED

I could probably look at this once my existing PR wraps up.

from magtape.

Thanks @ilrudie , I've assigned this issue to you.

from magtape.

@phenixblue Got a ci action for shellcheck running in my fork. Shellcheck finds a fair few things to complain about. Should fixing all the bash so shellcheck runs clean be part of this issue?

example output from my fork

from magtape.

No, I think that should be separate. The Kubernetes project setup a wrapper with an excludes file that lists scripts to skip so as to catch all net new scripts, but not block CI due to existing scripts. I think a similar approach here is good. Then we can to a separate PR per existing script to get stuff fixed over time.

Examples for reference:

• https://github.com/kubernetes/kubernetes/blob/master/hack/verify-shellcheck.sh
• https://github.com/kubernetes/kubernetes/blob/master/hack/.shellcheck_failures

from magtape.

I can just change how git selection works. Using a file I can add exemptions. This file maybe needs to go in .github/ somewhere.

File example:

# Select all .sh files
*.sh

# Exclude the following files under temporary legacy exemption
!hack/build-single-manifest.sh
!hack/patch-ca-bundle.sh
!hack/run-python-tests.sh
!hack/ssl-cert-gen.sh
!testing/export-env.sh

from magtape.