Git Product home page Git Product logo

Comments (6)

matthewmueller avatar matthewmueller commented on May 22, 2024

So I actually don't think this command should do a hard reset.

It looks like this command has been around for a while so maybe people are used to it, but it seems to me that the point of this bundle is to make git land an easier and more forgiving place...

To me, undo, reminds me of cmd + z. Cmd + z is quick, recoverable (with redo), and used without much thought or worry. Right now this command reverses your most recent commit, and potentially blows away an hour's worth of work along with it, an action that can't be reversed easily.

I think a warning message would be fine, but I also don't think the name of the command is quite right.

from git-extras.

tj avatar tj commented on May 22, 2024

yeah i dont disagree with that. I wasn't the one who added it ( and I've rarely used it because of this issue ), but a few people have done exactly what you mention. We could just get rid of it

from git-extras.

rauchg avatar rauchg commented on May 22, 2024

Let's get rid of it. I just had another accident with it haha

from git-extras.

muhtasib avatar muhtasib commented on May 22, 2024

How about letting it do a soft reset instead? This way users won't lose their changes. Previous files/changes will be in the local directory after the undo command is run.

I submitted a pull request for this. Let me know if you'd like me to make any changes. I like the command, so I advocate for keeping it : )

from git-extras.

bittner avatar bittner commented on May 22, 2024

This issue can be closed.

from git-extras.

spacewander avatar spacewander commented on May 22, 2024

Closed.

from git-extras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.