Merging issue_comment with pull_request about changed-files HOT 5 CLOSED

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

from changed-files.

Hi @Aetherinox, you might need to clarify the details of what you are trying to do and also provide logs and I.e not just a cut of the error but what lead up to the error.

from changed-files.

Sorry, I was half asleep last night when I wrote this, my brain wasn't firing on all cylinders.

After I woke up today, I'm not sure if this is even solvable by this action script. In short:

• My action has two triggers, issue_comment and pull_request
• When I do a pull request, the bot scans the changed files and checks them for syntax issues, generates a report using scripts/v7, and then comments in the pull request.
• The bot then assigns a label to the pull request depending on how the scan went.

I was wanting to implement a /rescan comment trigger, but what that would do is simply re-scan all the files again.

Well the problem with that, is that your script checks for changed / modified files. So if I simply do a /rescan, then obviously nothing is going to be changed without another pull request, which is where I say I'm not even sure if this action is even part of the problem. With no files being changed, my array doesn't get populated, which causes it to simply throw an error that it cannot find the creation_date of a file, because there aren't any files there to grab data for.

Then after I woke up today and did a double take, I realized that issue comments and pull requests have entirely different variables for grabbing data.

So it's something I'm going to have to investigate further, because what seemed like a relatively simple implementation, carries with it a web of differences.

from changed-files.

Hi @Aetherinox, actually issue_comment event is supported by this action you can find an full example here on how to setup your workflow.

These are example runs of the action for context on the list of files returned.

• PR comment: https://github.com/tj-actions/changed-files/actions/runs/8247880169/job/22556983266
• Issue comment (like this comment): https://github.com/tj-actions/changed-files/actions/runs/8247956283/job/22557227537

Let me know If that solves your issue or you’ll like further assistance.

from changed-files.

Ah, thank you for this. I'll have a look tomorrow.

Right now I wonder if I'm trying to throw way too much stuff into a single action, or if I should throw these into two actions. Once I look through these examples, I'll have a good idea.

Appreciate the examples.

from changed-files.