Git Product home page Git Product logo

Comments (9)

syoyo avatar syoyo commented on May 18, 2024

Cool!

I didn't know that .obj can support multiple materials per group.

Let me investigate your patch and think new data structure to support multi-materials per group. Usually the answer is assign per-face material ID like your patch.

from tinyobjloader.

syoyo avatar syoyo commented on May 18, 2024

I seems better to start adding support of multi-materials with your patch.
Could you please PR so that I can merge your modification?

from tinyobjloader.

sopyer avatar sopyer commented on May 18, 2024

I am sorry but I do not know what PR stands for. If you asking for permission to merge my patch then please go ahead, I have no objections. Just should warn you I modified only tinyobjloader.h/tinyobjloader.cpp and changed interface substantially. So it would be required to fix test/demo programs.

from tinyobjloader.

syoyo avatar syoyo commented on May 18, 2024

PR = pull request

https://help.github.com/articles/creating-a-pull-request

PR makes merging process easy.

from tinyobjloader.

sopyer avatar sopyer commented on May 18, 2024

Done.

from tinyobjloader.

syoyo avatar syoyo commented on May 18, 2024

Thanks!

I'm adding material_ids parameter per mesh, which holds per-face material ID.
This data structure is common for various renderers.

cbba0a8

If you think this modification looks OK, I'll proceed to merge it in master.

from tinyobjloader.

sopyer avatar sopyer commented on May 18, 2024

Well everything seems good. It is just a different use case then mine, though I see no significant problems adapting it. Unfortunately I can not test it. If everything works from your side, you probably should proceed with merge. Was happy to contribute:).

from tinyobjloader.

syoyo avatar syoyo commented on May 18, 2024

At least it seems working for cryteck sponza .obj > Unfortunately I can not test it

from tinyobjloader.

syoyo avatar syoyo commented on May 18, 2024

Merged into master. Thanks!

from tinyobjloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.