Currently, when the server returns a non-200 status code, we just propagate the low-le

We have this, BTW, it's just not being used consistently: <a href="h

I reckon <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Throw custom exceptions on errors about dotnet-kube-client HOT 8 CLOSED

tintoy commented on July 17, 2024

Throw custom exceptions on errors

from dotnet-kube-client.

Comments (8)

tintoy commented on July 17, 2024

Good idea! Have been meaning to do this - will look into it in an hour or so.

from dotnet-kube-client.

tintoy commented on July 17, 2024

We have this, BTW, it's just not being used consistently:

https://github.com/tintoy/dotnet-kube-client/blob/develop/src/KubeClient/KubeClientException.cs

from dotnet-kube-client.

tintoy commented on July 17, 2024

I reckon d13797a is a good start :)

Any feedback?

from dotnet-kube-client.

felixfbecker commented on July 17, 2024

Oh, I didn't realise that this already existed.
I am still getting HttpRequestException with DynamicClient.Patch() though...

from dotnet-kube-client.

tintoy commented on July 17, 2024

Interesting - you mean the non-generic HttpRequestException (rather than HttpRequestException<TResponse>)?

dotnet-kube-client/src/KubeClient/ResourceClients/DynamicResourceClient.cs

Lines 251 to 266 in d13797a

 // Ensure that HttpStatusCode.NotFound actually refers to the target resource. 

 StatusV1 status = await responseMessage.ReadContentAsAsync<StatusV1, StatusV1>(HttpStatusCode.NotFound).ConfigureAwait(false); 

 if (status.Reason == "NotFound") 

 { 

 string errorMessage = isNamespaced ? 

 $"Failed to patch {apiVersion}/{kind} resource '{name}' in namespace '{kubeNamespace}' (resource not found)." 

 : 

 $"Failed to patch {apiVersion}/{kind} resource '{name}' (resource not found)."; 

 throw new KubeClientException(errorMessage); 

 } 

 throw new KubeClientException($"Failed to patch {apiVersion}/{kind} resource (HTTP status {responseMessage.StatusCode}).", 

 innerException: new HttpRequestException<StatusV1>(responseMessage.StatusCode, status) 

 );

from dotnet-kube-client.

tintoy commented on July 17, 2024

Hi sorry for the silence on this end - as usual, work and life get in the way. Will be spending some more time on this tonight to add tests that verify error handling. Let me know if you have opinions or other input :)

from dotnet-kube-client.

tintoy commented on July 17, 2024

@felixfbecker - what do you reckon, is this test good enough?

d19dae0

PS. As a result of writing this test, I found and fixed the problem where you'd still see HttpRequestException<TResponse> instead of KubeClientException.

I'll try to get a proper release together before the end of this weekend :)

from dotnet-kube-client.

tintoy commented on July 17, 2024

This has been resolved as of the most recent release. Feel free to reopen if you hit any non-KubeClient exceptions that you think shouldn't be exposed to callers :)

from dotnet-kube-client.

Throw custom exceptions on errors about dotnet-kube-client HOT 8 CLOSED

Comments (8)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// Ensure that HttpStatusCode.NotFound actually refers to the target resource.
	StatusV1 status = await responseMessage.ReadContentAsAsync<StatusV1, StatusV1>(HttpStatusCode.NotFound).ConfigureAwait(false);
	if (status.Reason == "NotFound")
	{
	string errorMessage = isNamespaced ?
	$"Failed to patch {apiVersion}/{kind} resource '{name}' in namespace '{kubeNamespace}' (resource not found)."
	:
	$"Failed to patch {apiVersion}/{kind} resource '{name}' (resource not found).";


	throw new KubeClientException(errorMessage);
	}

	throw new KubeClientException($"Failed to patch {apiVersion}/{kind} resource (HTTP status {responseMessage.StatusCode}).",
	innerException: new HttpRequestException<StatusV1>(responseMessage.StatusCode, status)
	);