[Bug] Do not configure Maven to build an executable jar when generating a library about nxrocks HOT 6 CLOSED

Hi @tschaffter

I have already fixed that for library projects since v3.0.0 (see related #67).

In fact, during the generation of the project, if it is a library, I have added an additional step to remove the Spring Maven (or Gradle) plugin from the build file (following the same link you provided, from Spring documentation)

Do you have a repro case, where that plugin is still present in the pom.xml or build.gradle[.kts] after the generation of a library?

if so, can you share more ?

Thanks

from nxrocks.

Here is a screencast to illustrate the issue:

I'm using the version 4.1.0 of the plugin in this repo.

$ yarn info @nxrocks/nx-spring-boot version
yarn info v1.22.19
4.1.0
Done in 1.25s.

from nxrocks.

Thanks for the confirmation @tschaffter .

This is indeed a bug (in maven-based library projects): the way the removal of the plugin is implementef might be flawn.

This should be quick to fix, stay tuned!

from nxrocks.

🎉 This issue has been resolved in version @nxrocks/nx-spring-boot-v5.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

from nxrocks.

🎉 This issue has been resolved in version @nxrocks/nx-melos-v1.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

from nxrocks.

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from nxrocks.