[REQUEST] Provide flag to make all request inputs optional about protobuf-ts HOT 9 OPEN

There certainly are some situations where this would be handy.

This could be a separate client style, or maybe an option on the method level:

rpc Example (RequestMessage) returns (ResponseMessage) {
    option (ts.accept_partial) = true;
};

Main focus is releasing 2.0. It adds client styles and other features and has to become stable and could even need some simplification before this feature can be added on top.

In the meantime, there is always create():

// make a hat
let call = await client.makeHat( Size.create({ inches: 23 }) );

from protobuf-ts.

After pondering this for a while, I think partial request inputs should simply be the default behavior.

It adds a bit of a penalty because we will have to do a partial merge on the input, even if the input is complete. But convenience seems more important.

from protobuf-ts.

No worries! Thank you again for this wonderful project! It's head and shoulders above anything else currently available.

from protobuf-ts.

Denis, are you sure you want to stringify the message directly? Why not use the canonical JSON encoding instead. Response.toJsonString(response, {prettySpaces: 2}).

from protobuf-ts.

Reminder for the implementation: Creating a message from a partial instance discards unknown fields. It must still be possible (and should be the default) to keep unknown fields in a rpc round trip.

from protobuf-ts.

This won't make it into 2.0 😞 The API change is non-breaking, so it should be good to add in a minor release.

from protobuf-ts.

That is something that will useful for my case, because I need to render rpc response as is.
Like <code>{JSON.stringify(response, null, 2)}</code>.
And without proto3 optionals there is a lot of useless fields with empty strings.
So, any updates?

from protobuf-ts.

Didn't know that) Problem solved, perfect, thanks!

from protobuf-ts.

What's the status on this request? We'd like to migrate our frontend to protobuf-ts, but we have a large number of protos that don't use optional and it's not feasible to update them

from protobuf-ts.