Potential new initroduced bug in cockroach1055&cockroach1462 about gobench HOT 4 CLOSED

Could you reproduce this new bug? If so, I think we can post the backtrace of the new bug on cockroach1055

from gobench.

This bug is hard to reproduce in the original test file, but I've extracted the variable of s.drain related code, you can check the code in go playground here.

Here is the backtrace information in my IDE:

from gobench.

Thank you for pointing this out. I took a closer look and found that in the original code snippet, there was no explicit call for FinishTask (which actually called s.drain.Done()). That's why there’s more bugs. Great job!

from gobench.

Yes, and I also find due to this reason, there is another blocking bug related to condition variables in cockroach#1462. Since p.cond.Wait() is called in the test functioni, the corresponding p.cond.Broadcast() are not called for no call for FinishTask().
You can also check this in cockroach#1462.

Anyway, thanks for your reply~

from gobench.