Git Product home page Git Product logo

Comments (5)

lifthrasiir avatar lifthrasiir commented on June 7, 2024

To be exact, it is a common behavior that formatting implementations discard the width and alignment information:

fn main() {
    println!("{:>11?}", "a\nb\nc"); // not aligned
    println!("{:>11}", format!("{:?}", "a\nb\nc")); // aligned
}

I would argue that this behavior is, while frustrating, justifiable because alignment requires the length of printed string beforehand and this might not be acceptable for many types. (For the case of strftime, I think there is no efficient and seemingly-correct solution; Formatter::pad obviously requires the string length.) But it is frustrating, and I agree that this has to be discussed and at least documented.

from time.

vks avatar vks commented on June 7, 2024

If a type does not support alignment, then println! should fail at compile time IMHO.
Alas, this would not be backwards compatible. So we can only make it give a warning.

from time.

alexcrichton avatar alexcrichton commented on June 7, 2024

Yes @lifthrasiir is right in that most types do not support the width/alignment of the underlying formatting system, and the best solution to this (as you've found) is to call .to_string() and then pad that accordingly. This is currently as-intended, however, and the documentation should probably happen in std::fmt instead of just in this library, so I'm going to close this issue.

from time.

parkr avatar parkr commented on June 7, 2024

This is currently as-intended, however

Poop. Ok, that was really frustrating. Maybe a warning? A warning would have saved a lot of angst.

the documentation should probably happen in std::fmt instead of just in this library, so I'm going to close this issue.

Where can I submit a PR for that?

from time.

alexcrichton avatar alexcrichton commented on June 7, 2024

Maybe a warning? A warning would have saved a lot of angst

Unfortunately there's no way for the formatting infrastructure to know whether a type actually looks at the formatting flags or not (as it's all trait-based).

Where can I submit a PR for that?

A PR editing this file should do the trick!

from time.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.