Git Product home page Git Product logo

Comments (10)

tim-kos avatar tim-kos commented on August 10, 2024

Hey kof,

please explain "all functions of object obj". Shouldn't this be an array of functions? Or maybe I am not getting the big picture.

from node-retry.

kof avatar kof commented on August 10, 2024
// wrap all methods of myLibrary object
retry.wrap({retries: 3}, myLibrary);
// wrap only named methods of myLibrary object
retry.wrap({retries: 3}, myLibrary, ['method1', 'method2', 'method3']);

from node-retry.

kof avatar kof commented on August 10, 2024

even better

// wrap all mehtods of myLibrary using default options
retry.wrap(myLibrary);

// wrap all methods of myLibrary object
retry.wrap(myLibrary, {retries: 3});

// wrap only named methods of myLibrary object
retry.wrap(myLibrary, {retries: 3}, ['method1', 'method2', 'method3']);

from node-retry.

kof avatar kof commented on August 10, 2024
function wrap(obj, options, methods) {
    if (options instanceof Array) {
        methods = options;
        options = null;
    }

    if (!methods) {
        methods = Object.keys(obj);
    }

    methods.forEach(function(method) {
        var origin = obj[method];

        if (typeof origin != 'function') {
            return;
        }

        obj[method] = function() {
            var op = retry.operation(options),
                args = Array.prototype.slice.call(arguments),
                callback = args.pop();

            args.push(function(err) {
                if (op.retry(err)) {
                    return;
                }
                if (err) {
                    arguments[0] = op.mainError();
                }
                callback.apply(this, arguments);
            });

            op.attempt(function() {
                origin.apply(obj, args);
            });
        };
    });    
}

from node-retry.

kof avatar kof commented on August 10, 2024

It needs some changes to support all browsers ... but basically thats it.

from node-retry.

tim-kos avatar tim-kos commented on August 10, 2024

I see. Pretty interesting.

If you could also write some tests for it I'd merge a PR for this one.

from node-retry.

kof avatar kof commented on August 10, 2024

What are requirements for the environment? Is this module supposed to be used in browser? Or just node?

from node-retry.

tim-kos avatar tim-kos commented on August 10, 2024

For now it's just supposed to be used out of node, but I am sure it can be used easily in the browser with node-browserify.

from node-retry.

seriousManual avatar seriousManual commented on August 10, 2024

bump!

from node-retry.

tim-kos avatar tim-kos commented on August 10, 2024

Will finish this and merge the related PR.

from node-retry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.