Option to unref timers about node-retry HOT 6 CLOSED

Reference: https://nodejs.org/api/timers.html#timers_unref

from node-retry.

Looks good to me, with the exception that it breaks the API now for the RetryOperation initialization. It now awaits an object as the second parameter, whereas before you could use a boolean for retryForever.

Could you please add code that fixes this? Something like:

if (typeof options == 'boolean') {
   var retryForever = options;
   options = {
      retryForever: retryForever,
      unref: false
   }
}

Then I'll happily merge this. Thanks for the contribution!

from node-retry.

@tim-kos done, I've simplified your suggestion a bit: https://github.com/tim-kos/node-retry/pull/27/files#diff-5fbd26cd639da16ee356ed75e5ff2334R2

from node-retry.

<3

On Tue, Jan 26, 2016 at 9:27 AM, André Cruz [email protected]
wrote:

@tim-kos https://github.com/tim-kos done, I've simplified your
suggestion a bit:
https://github.com/tim-kos/node-retry/pull/27/files#diff-5fbd26cd639da16ee356ed75e5ff2334R2

—
Reply to this email directly or view it on GitHub
#26 (comment).

from node-retry.

Cool! Can you please release a new version (perhaps a stable 1.0.0)? Thanks <3

from node-retry.

Done!

On Tue, Jan 26, 2016 at 11:48 AM, André Cruz [email protected]
wrote:

Cool! Can you please release a new version? Thanks <3

—
Reply to this email directly or view it on GitHub
#26 (comment).

from node-retry.