Replace buffer individual byte peeking with indexOf(ByteString) about tikxml HOT 9 OPEN

Thanks for the hint. Does that makes any difference regarding performance?

Jake Wharton [email protected] schrieb am Mi., 1. Juni 2016, 16:56:

For example, this can be replaced with

private static final ByteString CDATA_CLOSE = ByteString.decodeUtf8("]]>");// ...long index = source.indexOf(CDATA_CLOSE);if (index == -1) throw ...return index;

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#25, or mute the thread
https://github.com/notifications/unsubscribe/AAjnrge7qhP1NcmGlZZSP6kbWWfsqubrks5qHZ2UgaJpZM4Iro3S
.

from tikxml.

No. Just code reduction on your part.

from tikxml.

👍

from tikxml.

this could fix the issue with a json array inside cdata.

from tikxml.

Is this bug is still good?

from tikxml.

It is, although it is not a bug. It's just for better code readability.

from tikxml.

What does need to be change from https://github.com/Tickaroo/tikxml/blob/master/core/src/main/java/com/tickaroo/tikxml/XmlReader.java#L663

from tikxml.

Its already replaced on this place.

from tikxml.

https://github.com/Tickaroo/tikxml/blob/master/core/src/main/java/com/tickaroo/tikxml/XmlReader.java#L305 and https://github.com/Tickaroo/tikxml/blob/master/core/src/main/java/com/tickaroo/tikxml/XmlReader.java#L790 can be simplified.

from tikxml.