Git Product home page Git Product logo

Comments (16)

iNoles avatar iNoles commented on June 25, 2024

Is anyone is working for this?

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

I don´t think so. Im sure he would accept a pr.

from tikxml.

sockeqwe avatar sockeqwe commented on June 25, 2024

No i'm not working on that, but should be done until 1.0. The question is if we do want to do that in maven or gradle.

The original plan was to stick with maven (has some better support with annotation processing testing), and simply push a .aar file from maven (android maven plugin) containing proguard rules and dependencies to core and annotation artifact

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

Gradle would require a new publish script, but would also be better compatible with android studio.

from tikxml.

sockeqwe avatar sockeqwe commented on June 25, 2024

publish script is not an issue. The main issue is that gradle + java module + annotation processing (i.e. for annotationprocessingtesting ) doesn't work well out of the box. That's the reason why apt plugin for android exists.

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

thats true, the annotation processor dependencies has to be java modules.

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

Maybe the new jack compiler with annotation processing support will change something there?

from tikxml.

sockeqwe avatar sockeqwe commented on June 25, 2024

i would prefer to stick with java modules. this parser is not android exclusive.

All modules are plain java modules (except this android module with proguard rules).

The main problem is that for testing I have a annotationprocessingtesting module which depends on the processor module (kind of integration test) and here gradle fails (or I didn't have enough time to check how to configure gradle properly with annotation processing).

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

you have tested if the new jack compiler can run the tests?

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

the jack compiler is supporting annotationProcessor 'com.google.dagger:dagger-compiler:2.0'for example.

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

https://android.googlesource.com/toolchain/jack/+/ub-jack-lang-dev/jack-tests/tests/com/android/jack/error/AnnotationProcessorErrorTest.java

from tikxml.

sockeqwe avatar sockeqwe commented on June 25, 2024

i haven't tested jack ...I prefer to use maven or gradle for this project
...

Fabian Terhorst [email protected] schrieb am Sa., 11. Juni 2016,
20:10:

the jack compiler is supporting annotationProcessor
'com.google.dagger:dagger-compiler:2.0'for example.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#17 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAjnrpZ0C5XNuOiQrKc2uzRuzAMkICb9ks5qKvofgaJpZM4HQBVO
.

from tikxml.

sockeqwe avatar sockeqwe commented on June 25, 2024

For now I would prefer this:
https://simpligility.github.io/android-maven-plugin/aar.html

it should be as simple as putting a proguard file into a new maven module that uses this maven plugin

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

how you get the project currently well imported into android studio?

from tikxml.

sockeqwe avatar sockeqwe commented on June 25, 2024

I use Intellij for plain java projects (like this one) and not Android Studio, then Import project --> root pom.xml file

from tikxml.

FabianTerhorst avatar FabianTerhorst commented on June 25, 2024

Okay, Android Studio doesn't support importing a Maven project.

from tikxml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.