Git Product home page Git Product logo

Comments (3)

ThunderEX avatar ThunderEX commented on August 17, 2024 1

I don't know any python, but isn't it unpractical to maintain two different versions of the same software?

Both ways are practical. But a well-maintained code should have cross-platform compatibility, but not implement separately for different platforms.

Is it possible to update it without using LicenseManager or vlmcsd? Otherwise, dependence on someone else's software may be not the best strategy.

Firstly and of source, it could be updated manually without LicenseManager or vlmcsd. Secondly, in most situations, kms data updates are just copying LicenseManager converting to python and pasting here. I don't want to do such manual work and don't want to receive such pull request. For those who cry for Windows / Office 202x support, they can easily do it themselves without my update.

from py-kms.

ThunderEX avatar ThunderEX commented on August 17, 2024

I've done these changes since I started work on this project:

  1. compatibility fixes: original py-kms only support python 2, I adapted to support both versions, and ensure it work on pypy & micropython. It seems SystemRage's version actually have 2x different folder to support python 2 and 3 separately, and as I tested it doesn't work on pypy3 or micropython.
  2. from this article, original py-kms return wrong RPC stub size although wrong stub size could still be recognized by MS client. I fixed this problem.
  3. original py-kms use a file of KmsBase.py gathering Csvlk info. If MS release a newer version of software, someone need to update this file. I replace this file with KmsDataBase.xml which is compatible with another tool vlmcsd. So you just need to get a newer KmsDataBase.xml from LicenseManager or vlmcsd without edit source code.
  4. original py-kms use wrong active client number, and with csvlk host info not updated. You could see error / warning if using vlmcsd / LicenseManager. And if your client is activated using original py-kms, it's possible to distinguish it from a genuine client.
  5. other bug fixes (such as SystemRage/py-kms#8), and improvements.

On the other hand, SystemRage's project has a nice output in terminal. He also has a wiki of a brief guide. So if someone could help improve on my repo, please give me a hand with a PR.

from py-kms.

dimqua avatar dimqua commented on August 17, 2024

Thanks for clarifying!

SystemRage's version actually have 2x different folder to support python 2 and 3 separately

I don't know any python, but isn't it unpractical to maintain two different versions of the same software?

I replace this file with KmsDataBase.xml which is compatible with another tool vlmcsd

Is it possible to update it without using LicenseManager or vlmcsd? Otherwise, dependence on someone else's software may be not the best strategy.

He also has a wiki of a brief guide.

Can't you just copy-paste it to here? :-)

from py-kms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.