Git Product home page Git Product logo

Comments (4)

MischaPanch avatar MischaPanch commented on August 17, 2024 1

I will close it, we can discuss later, when the refactoring of experiment is closer to being merged.

Just didn't want to close without an explanation, since you likely got an email before I did the edit

from tianshou.

opcode81 avatar opcode81 commented on August 17, 2024

How can there be any confusion? The agent factory's create method is not a method a user is likely to ever call, as the high-level API performs all object creation tasks behind the scenes. And the prefilling of the collector is clearly logged, after all, so I don't really see how it could create any confusion.

The reasoning is that the creation method is supposed to provide collectors that can directly be used for training. So if the collectors shall be prefilled before the training begins, then the method takes care of that.

from tianshou.

MischaPanch avatar MischaPanch commented on August 17, 2024

Let's discuss in a call, this arose in an experimental refactoring of the experiment where the pre-filling behavior on creation gets in the way

from tianshou.

opcode81 avatar opcode81 commented on August 17, 2024

So what is this issue really about? Specifying the number of episodes instead of steps?
Please update the description and delete the superfluous/outdated stuff.

from tianshou.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.