Comments (4)
I will close it, we can discuss later, when the refactoring of experiment is closer to being merged.
Just didn't want to close without an explanation, since you likely got an email before I did the edit
from tianshou.
How can there be any confusion? The agent factory's create method is not a method a user is likely to ever call, as the high-level API performs all object creation tasks behind the scenes. And the prefilling of the collector is clearly logged, after all, so I don't really see how it could create any confusion.
The reasoning is that the creation method is supposed to provide collectors that can directly be used for training. So if the collectors shall be prefilled before the training begins, then the method takes care of that.
from tianshou.
Let's discuss in a call, this arose in an experimental refactoring of the experiment where the pre-filling behavior on creation gets in the way
from tianshou.
So what is this issue really about? Specifying the number of episodes instead of steps?
Please update the description and delete the superfluous/outdated stuff.
from tianshou.
Related Issues (20)
- will add dreamerv3 ? HOT 1
- Documentation for multi-agent needs fixing HOT 1
- No minibatch for computation of logp_old in PPOPolicy HOT 1
- MPO Implementation HOT 1
- Improve interface of BasePolicy.compute_action HOT 1
- Suggestion - Redesign RayEnvWorker for Improved Performance HOT 12
- tianshou v1.0.0 failed to install on python 3.12.4 HOT 2
- How to add a obs with multiple dimensions to the buffer?
- TypeError: isinstance() argument 2 cannot be a parameterized generic HOT 1
- Make Batch.__eq__ work also for scalar values (0-dimensional arrays) HOT 2
- EOFError on training HOT 8
- ModuleNotFoundError: No module named 'tianshou.highlevel' HOT 3
- Cannot unify float64 and array(float64, 1d, C) for 'gae.2'
- Discrete distributions are broken HOT 2
- Actor and distribution function should not be specified independently HOT 1
- Learning rate scheduler confusion HOT 1
- Handling LR scheduling when episodes instead of steps are collected
- Release 1.1.0 to pypi HOT 1
- Refactoring: make Trainer more flexible
- Support custom scores for Trainer in high-level interfaces
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tianshou.