Ignore Tests not counted up about unity HOT 4 CLOSED

Philipp,

This fix works correctly if the ignored test is the last test to run. But it introduces a new bug if the ignored test is the 2nd to last test to run:

Unity test run 1 of 1

........!.

10 Tests 0 Failures 2 Ignored
OK

Did you write a Unity test for this code ;-) ?

-John-

From: PhilippMeier [mailto:[email protected]]
Sent: Wednesday, November 07, 2012 6:31 AM
To: ThrowTheSwitch/Unity
Subject: [Unity] Ignore Tests not counted up (#14)

function "UnityIgnoreTest" (defined in unity_fixture.c) misses to count up "Unity.TestIgnores". This then lead to the test result showing "0 Ignored" when it should show "1 Ignored".

I guess the fix for this bug is to change

void UnityIgnoreTest()

{

Unity.NumberOfTests++;

Unity.CurrentTestIgnored = 1;

UNITY_OUTPUT_CHAR('!');

}

to

void UnityIgnoreTest()

{

Unity.NumberOfTests++;

Unity.TestIgnores++;

Unity.CurrentTestIgnored = 1;

UNITY_OUTPUT_CHAR('!');

}

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/14.

Disclaimer: This message and any files or text attached to it are intended only for the recipients named above and contain information that may be confidential or privileged. If you are not an intended recipient, you must not forward, copy, use or otherwise disclose this communication or the information contained herein. In the event you have received this message in error, please notify the sender immediately by replying to this message, and then delete all copies of it from your system. Thank you.

from unity.

John

As you can see when you are logged in to Github directly, I changed my original description because in the meantime I found the same issue as you describe. I have no solution yet - I hoped to not be the first one...

Philipp

from unity.

This bug was fixed in commit e21881c.
@mvandervoord Will you close this issue?

from unity.

:) Thanks!

from unity.