Digest exception when using a protected zip file (with password) in the application package about getdown HOT 5 OPEN

Hi @serge-xav,

in my opinion computing zip file digest in a robust way is an important improvement. So #275 is the implication of a change to an unsafe implementation.

For your mentioned bug here, the best solution would be a fallback to the default digest calculcation, when the zip file is encrypted.

Another solution would be to change the extension to ".zip.dat", so getdown don't tries to open the file.

from getdown.

Hi @bekoenig, thanks for your comment.
I will try to implement your workaround for encrypted zip files. If a correction is needed on Getdown side, do you know when/how the new digest calculation has been implemented for zip files ? I tried to take a look at it, but I don't know how to implement the "fallback to default digest calculation when zip file is encrypted"

from getdown.

In the next weeks getdown 2.0.0 will be released with different group-id (see bekoenig/getdown#1). This version is feature complete and waits for final release. After this, I can implement this fallback in

from getdown.

Hi again Benjamin, I did not see this announcment before, that's good news to see Getdown up and living. Do you want me to also create the issue on your project ?

from getdown.

You are welcome to open a new issue in my repository. I will try to fix it in the next month.

After the first release I will open a new issue here to mark this repository as deprecated and link to my fork. I'm new to github and opensource contribution, so I need time to adapt my wellknown processes.

from getdown.