Git Product home page Git Product logo

Comments (4)

yoruvo avatar yoruvo commented on August 15, 2024 1

I was able to fix it for my use case. The above code snippet removes the TS errors, and the problem with my key was algorithm RS256 instead of the default. Now, it seems to work.

However there was basically no feedback from the library on what was going on, and whether there was or wasn't a connection. It would be nice to have an option to see why the authorization failed.

from socketio-jwt.

theoludwig avatar theoludwig commented on August 15, 2024

Thanks for your report! @yoruvo
So as I understood you find out how to fix your problem but you would like to have more/better error message so you could fix it more easily. Also that, decodedToken should have a better type.

Sounds good to me, we're open to PR, if you have some time to open a PR to improve that, we would really appreciate it! 👌

from socketio-jwt.

yoruvo avatar yoruvo commented on August 15, 2024

Hi @divlo,

part of my issue came from my own mistake of using the wrong algorithm, sure. Still, the fact remains that your TS server example in the README doesn't work at all, due to the reasons outlined in the ticket.

Above I wrote some example code that does work, but it's quite ugly because your typing for decodedToken is either null, string, or a Record<string,any>. Is that supposed to be the case? Is it possible for decodedToken to be all these things in a JWT token context? I'm not familiar with the architecture, but it seems too lightly typed.

from socketio-jwt.

theoludwig avatar theoludwig commented on August 15, 2024

Indeed, the typings were wrong for decodedToken, I released @thream/[email protected] so now the example in the README work as expected, feel free to open others issues if any.
Thanks again for your contribution and hopefully it fix your problem. 🎉 @yoruvo

from socketio-jwt.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.