Updating from 6.2.0 -> 6.4.2 is a breaking change for us: "Do not define "id". Instead, rely on the database to generate it." about factory_bot HOT 7 OPEN

Seems like the kind of breaking change that should warrant a major version number increment.

from factory_bot.

https://github.com/thoughtbot/factory_bot_rails/blob/54c72541ac8d9afa2c94274d80597c24112ce054/README.md?plain=1#L168C1-L168C57 should help.

from factory_bot.

I'd suggest a more prominent announcement, e.g., at the top of the README, to close this one out.
Call it an inadvertent breaking change and point to the docs for how to get the old behavior.

from factory_bot.

I'm happy that there is a feasible way to revert back to the old behavior and this has addressed my personal needs. I do however agree with @BiggerNoise : a more prominent mention would be very helpful. What about either:

• Mentioning the config value in the error message?
• Mention the error message in the Readme?

from factory_bot.

Agree that being able to revert to the previous behavior has met my needs as well.

I think @MarcusRiemer documentation suggestions would be very helpful, would a P/R be helpful?

from factory_bot.

One issue with turning off via config.factory_bot.reject_primary_key_attributes = false is that for Rails engines this needs to go in the dummy app, not in say spec_helper.

from factory_bot.

Within the context @pyromaniac, I think we can close this "bug". It's more like a configurable feature.

p.s. this feature was a surprise to me, too.

from factory_bot.