Shifty does not disable at sunrise. about shifty HOT 10 CLOSED

Fixed in 67b01f4. Thanks for the lead @choco. That's exactly what was happening.

from shifty.

@jostyee I’m planning on putting out an update today.

from shifty.

I was just about to open an issue myself. I've been experiencing the exact same problem:

1. Night Shift is enabled from Sunset to Sunrise
2. I close my computer lid at night when Night Shift is enabled
3. I reopen it in the morning after sunrise, Night Shift is still enabled and won't automatically deactivate

from shifty.

I've met the same issue with v0.4, while v0.3 worked well.

from shifty.

I've been experiencing the issue described by choco since I started using the app (v0.2 if I remember correctly). Definitely happened on v0.3 for me as well. Just updated to v0.4, so can't say for that version just yet..

from shifty.

Same with me. Some additional points.

1. On the login screen at wake up night shift is correctly disabled, but will be activated once I log in.
2. Dark mode will toggle correctly. So at sunrise it is disabled, but night shift will stay active.

I've also started with v0.3, v0.3 hase the same problem.

from shifty.

I've experienced this at least as far back as 0.2. I don't really have any idea what is causing this yet. In 0.3, I added a check on screen wake to set Night Shift to its scheduled state. Obviously that doesn't appear to have worked. I will double check this code soon to make sure it's working as intended, but it's tough since this issue is hard to reproduce. It doesn't even happen every morning for me.

I'm wondering if this is possibly a macOS bug. Has anyone experienced this while Shifty is not running?

@villiansv Is IINA still in the foreground when you open your computer? Night Shift should definitely not be enabled in that case.

from shifty.

@thompsonate No IINA is not running. I quit it before going to bed. I also don’t experience the issue every day but it does happen more often than not.

from shifty.

By taking a quick look isShiftForAppEnabled may not get updated since Shifty may miss the blueLightNotification in this situation. I think a good solution would be to update isShiftForAppEnabled in the action of the observer for screensDidWakeNotification

from shifty.

@thompsonate When can we get an update w/ this fix? It's really annoying.

from shifty.