Server join broken about pledge HOT 12 CLOSED

I also started getting this on 1.8

from pledge.

I am currently working on a fix for this, you can use version 2.2 for the moment

from pledge.

As it stands now I am unable to reproduce it, on paper current paper version, no plugins with only pledge active

from pledge.

I force deployed a new build to the maven repository, let me know if this fixes it.
If not please provide me with the following information:

• Bungeecoord enabled / disabled
• Compression threshold
• Last server log file

from pledge.

I've confirmed this as fixed on the latest build with another user, let me know if this is also resolved on the latest build

from pledge.

Hello! Sorry, misclick.

I've tested on the lastest build (2.3 from repo) and the problem still persists for me

1. BungeeCord mode is disabled.
2. network-compression-threshold=0
3. The lastest log: https://mclo.gs/nCGvg9O

from pledge.

Hello, this should be resolved in update 2.4. Let me know if you're still experiencing issues.

from pledge.

Yup, now it works but incompatible with ProtocolLib. 😵
Edit: sometimes it cannot make handler even w/o ProtocolLib

[05:31:01 ERROR]: Could not pass event PlayerLoginEvent to PledgeTest v1.0
org.bukkit.event.EventException: null
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:72) ~[patched_1.12.2.jar:git-Paper-1620]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[patched_1.12.2.jar:git-Paper-1620]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.12.2.jar:git-Paper-1620]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:513) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.PlayerList.attemptLogin(PlayerList.java:565) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.LoginListener.b(LoginListener.java:152) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.LoginListener.e(LoginListener.java:68) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.NetworkManager.a(NetworkManager.java:273) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.ServerConnection.c(ServerConnection.java:150) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:948) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:423) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:774) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:666) ~[patched_1.12.2.jar:git-Paper-1620]
        at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.lang.RuntimeException: Could not get channel for player: f4n74z14
        at dev.thomazz.pledge.channel.ReflectiveChannelAccess.getChannel(ReflectiveChannelAccess.java:68) ~[?:?]
        at dev.thomazz.pledge.PledgeImpl.onPlayerLogin(PledgeImpl.java:213) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor11.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Paper-1620]
        ... 13 more
Caused by: java.lang.NoSuchFieldException: Could not find field in class net.minecraft.server.v1_12_R1.HandshakeListener with names [EntityPlayer]
        at dev.thomazz.pledge.util.ReflectionUtil.getFieldByClassNames(ReflectionUtil.java:21) ~[?:?]
        at dev.thomazz.pledge.channel.ReflectiveChannelAccess.getChannel(ReflectiveChannelAccess.java:57) ~[?:?]
        at dev.thomazz.pledge.PledgeImpl.onPlayerLogin(PledgeImpl.java:213) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor11.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Paper-1620]
        ... 13 more

Edit 2: This happens if player kicked on login state

  [03:49:58 WARN]: [io.netty.util.concurrent.AbstractEventExecutor] A task raised an exception. Task: dev.thomazz.pledge.PlayerHandler$$Lambda$1066/0x00000008015cecd8@2516655c
  java.lang.RuntimeException: java.lang.NullPointerException: Cannot invoke "io.netty.channel.ChannelHandlerContext.pipeline()" because "ctx" is null
    at dev.thomazz.pledge.PlayerHandler.lambda$tickEnd$1(PlayerHandler.java:131) ~[?:?]
    at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) ~[patched_1.12.2.jar:git-Paper-1620]
    at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) ~[patched_1.12.2.jar:git-Paper-1620]
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463) ~[patched_1.12.2.jar:git-Paper-1620]
    at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) ~[patched_1.12.2.jar:git-Paper-1620]
    at java.lang.Thread.run(Thread.java:833) [?:?]
    Caused by: java.lang.NullPointerException: Cannot invoke "io.netty.channel.ChannelHandlerContext.pipeline()" because "ctx" is null
    at dev.thomazz.pledge.network.PacketFrameOutboundHeadHandler.drain(PacketFrameOutboundHeadHandler.java:109) ~[?:?]
    at dev.thomazz.pledge.PlayerHandler.lambda$tickEnd$1(PlayerHandler.java:129) ~[?:?]
    ... 5 more

from pledge.

First exception seems very weird since it seems like a handshake listener instead of a login listener is found even though the login listener is called? The second issue should be fixed in 8e0dff8, feel free to verify if your issue is resolved.

from pledge.

First exception seems very weird since it seems like a handshake listener instead of a login listener is found even though the login listener is called?

Yes, that weird, but sometimes it happens.

from pledge.

@gbomexify Create a new issue for this

from pledge.

Closing this now, if any other problems are encountered feel free to create another issue

from pledge.