subfields of absolute number fields about hecke.jl HOT 5 CLOSED

Thanks and good catch. Did you enconter an actual error? Just curious.

We will have a look soonish.

from hecke.jl.

After discovering the Hecke implementation, I didn't dare using it given that "Claus says its wrong".

from hecke.jl.

@martinra We would love to take your version either by PR or just as a snippet here. But we would need to fit it into the generator/basis setting, i.e., it would have to replace the _subfield_basis(K, elt) function.

from hecke.jl.

Just to make sure, _subfield_basis is meant to compute a vector space basis of the subfield over the base field. Correct? Then I'll prepare a pull request soonish.

You seem to have a number of tests for subfields, but none for subfield. Should I add one or two cases?

from hecke.jl.

Just to make sure, _subfield_basis is meant to compute a vector space basis of the subfield over the base field. Correct? Then I'll prepare a pull request soonish.

Yes, correct, thanks!

You seem to have a number of tests for subfields, but none for subfield. Should I add one or two cases?

More tests are of course always welcome :)

from hecke.jl.