Recursing too deep in ColumnFamilyIterator->next() about phpcassa HOT 3 CLOSED

This patch seems to fix the problem but I haven't done extensive testing.

--- a/util/phpcassa/columnfamily.php
+++ b/util/phpcassa/columnfamily.php
@@ -1225,21 +1225,28 @@ class ColumnFamilyIterator implements Iterator {
if (count(current($this->current_buffer)) == 0)
{
# this is an empty row, skip it

•            $key = key($this->current_buffer);
  

•            $this->next();
  

•            while (count(current($this->current_buffer)) == 0) {
  

•                   $this->next_start_key = key($this->current_buffer);
  

•                   next($this->current_buffer);
  

•                   $key = key($this->current_buffer);
  

•                   if ( !isset($key) ) {
  

•                           $beyond_last_row = true;
  

•                           break;
  

•                   }
  

•           }
  

•        }
  

•        else {
  

•               $key = key($this->current_buffer);
  

•               $beyond_last_row = !isset($key);
       }
  

•        else # count > 0
  

•        if (!$beyond_last_row)
       {
  

•            $key = key($this->current_buffer);
  

- $beyond_last_row = !isset($key);

•            if (!$beyond_last_row)
  

•            {
  

•                $this->rows_seen++;
  

•                if ($this->rows_seen > $this->row_count) {
  

•                    $this->is_valid = false;
  

•                    return;
  

•                }
  

•            $this->rows_seen++;
  

•            if ($this->rows_seen > $this->row_count) {
  

•                $this->is_valid = false;
  

•                return;
           }
       }
   }
  

from phpcassa.

Would you mind opening a pull request for this? You can find instructions here: http://help.github.com/send-pull-requests/

This is definitely a bug, and I appreciate you taking the time to come up with a patch. Thanks!

from phpcassa.

done, pull request sent

from phpcassa.