Initial Spinup Tazks about template-drupal8 HOT 15 CLOSED

Another thing we need to consider @pirog is that our travis files are completely different and that could cause problems

from template-drupal8.

from template-drupal8.

Theirs doesnt use any lando and there is more steps as they do things more natively + use simplytest me: https://github.com/platformsh/template-drupal8/blob/master/.travis.yml

As compared to ours: https://github.com/thinktandem/template-drupal8/blob/master/.travis.yml

@pirog

from template-drupal8.

@labboy0276 ahhh right, sorry, i thought you were talking about the start state's travis yaml and then downstream ones eg minimis and projects. Those should be more or less the same.

I'm not really sure how to handle these situations but i think the best thing we can do for now is just rename their file to .travis.platform.sh and then spin up ours next to it. You have a better idea?

from template-drupal8.

OK, there isnt much we can do and we will just have to manually adjust things at times @pirog

from template-drupal8.

I used our project github templating for now as well

from template-drupal8.

@pirog most things are done, can you spin up a platform instance for this?

from template-drupal8.

travis is failing hard, need to stare more later on

from template-drupal8.

We have to use a separate lando for travis because lando will get spit out warnings over the fact these vars are not set during build and start:

        PLATFORMSH_CLI_TOKEN: "$PLATFORMSH_CLI_TOKEN"
        PLATFORMSH_PROJECT_ID: "$PLATFORMSH_PROJECT_ID"

from template-drupal8.

from template-drupal8.

OK, it has been banished then

from template-drupal8.

@pirog I noticed I have php codesniffer in travis & codeclimate. Should I leave it like that or remove one from one of the testing (I suggest taking it out of travis) ?

from template-drupal8.

i think its good to have it both because we arent super clear on whether we want to use codeclimate everywhere yet

from template-drupal8.

@pirog as discussed this is good to go, any future tasks can be split off into their own cards

from template-drupal8.

lets just roll fast and hard with our QA since our minds are one

from template-drupal8.