The weather station shows a wrong moon phase about esp8266-weather-station HOT 6 CLOSED

Which demo sketch are you using?

from esp8266-weather-station.

Hi Marcel, thanks for your reply. Demo? What do you mean?

from esp8266-weather-station.

I'm simply wondering what your sketch is and whether you use the simple Astronomy class or the more elaborate SunMoonCalc class. There are examples for both: https://github.com/ThingPulse/esp8266-weather-station/blob/master/examples/AstronomyDemo/AstronomyDemo.ino, https://github.com/ThingPulse/esp8266-weather-station/blob/master/examples/SunMoonCalcDemo/SunMoonCalcDemo.ino

from esp8266-weather-station.

Okay, it's clear now. My sketch is based on Astronomy class. Just a copy & paste of the demo code:

Astronomy *astronomy = new Astronomy();
moonData = astronomy->calculateMoonData(now);
moonData.phase = astronomy->calculateMoonPhase(now);
delete astronomy;
astronomy = nullptr;

Then moonData.illumination and moonData.phase are used to estimate the moon age:

float lunarMonth = 29.53;
gfx.drawString(235, 276, String(moonData.phase <= 4 ? lunarMonth * moonData.illumination / 2.0 : lunarMonth - moonData.illumination * lunarMonth / 2.0, 1) + "d");

The divergence seems to be more accentuated at the very beginning of lunar cycle (New Moon). Today October 18th, at almost half cycle, code returns Waxing Gibbous moon, with 97% illumination and 14,4 days age, which is pretty much exact. "Real" values are very close: 96% and 12,76 days age.

A better approximation (i.e. 29.53059...) of lunar month duration should not have any effect... right?
Many thanks in advance for your suggestions.

from esp8266-weather-station.

Maybe try the SunMoonCalc class instead as it's more elaborate. However, as disclosed in that class and in https://github.com/ThingPulse/esp8266-weather-station/blob/master/src/Astronomy.cpp all of those algorithms are not ours. We only ported existing code to Arduino/ESP8266. However, I just realized some links to the original sources are now void. Maybe we should replace them with Archive links like these https://web.archive.org/web/20210429120530/https://www.voidware.com/moon_phase.htm.

A better approximation (i.e. 29.53059...) of lunar month duration should not have any effect... right?

I don't think that's what you really meant 😜 It should have an effect - more accurate results - otherwise improving it would be pointless, no?

Feel free to propose changes if you can confirm that they yield more accurate results, thanks.

from esp8266-weather-station.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from esp8266-weather-station.