Git Product home page Git Product logo

Comments (3)

Thie1e avatar Thie1e commented on July 20, 2024

Hi, thanks for the report. We have a unit test that checks if the F1-scores from cutpointr are identical to the ones returned by ROCR, so I hope the results from cutpointr are correct.

I'll look into it and will try to check why the difference occurs.

If you have a look at cutpointr::F1_score you'll see that the code is basically identical to yours:

function(tp, fp, tn, fn, ...) {
    f <- (2 * tp) / (2 * tp + fp + fn)
    f <- matrix(f, ncol = 1)
    colnames(f) <- "F1_score"
    return(f)
}

from cutpointr.

Thie1e avatar Thie1e commented on July 20, 2024

Upon reviewing the issue, I'm noticing that you're hardcoding the positive class to be 1, the negative class to be 0 and direction = ">=", so that values larger than the threshold indicate the positive class. As the output from cutpointr() states (also via the messages #> Assuming the positive class is 0 and #> Assuming the positive class has higher x values), it assumes that the positive class is 0 because it is the class with the higher median value for df_test$resp.

If you simply specify classes and direction as follows, you'll get an F1-score that is identical to the one from your function:

> cp <- cutpointr(data = df_test, x = pred, class = resp, 
+                 method = maximize_metric, metric = F1_score,
+                 pos_class = 1, direction = ">=")
> cp %>% select(optimal_cutpoint, F1_score)
# A tibble: 1 x 2
  optimal_cutpoint F1_score
             <dbl>    <dbl>
1      0.000465349 0.663995
> dice(pred = df_test$pred, label = df_test$resp, thr = cp$optimal_cutpoint)
[1] 0.6639947

from cutpointr.

Tazinho avatar Tazinho commented on July 20, 2024

I guess I was somehow confused ;-)
Thanks a lot for taking the time to review this and also for pointing out the reasonable messages.
Indeed super clear.

from cutpointr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.